Fix RemoteChannel iterator interface #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielwe
force-pushed
the
remotechannelsize
branch
2 times, most recently
from
282ad6a to
6abf60b
Compare
Contributor
Author
|
CI seems to be running new tests with old code |
Member
|
Strange. The source diff LGTM, and I can confirm locally that it fixes an undefined value error. I don't know what is going on with the tests and am not familiar with the testing infrastructure of this repo. |
fatteneder
force-pushed
the
remotechannelsize
branch
from
6abf60b to
b952a65
Compare
Member
|
The rebase fixed the tests. |
fatteneder
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a missing import